Skip to content

UI action is disabled for several selected classes or packages #882#896

Merged
Vassiliy-Kudryashov merged 2 commits into
mainfrom
Vassiliy-Kudryashov/882-ui-action-is-disabled-for-several-selected-classes-or-packages
Sep 12, 2022
Merged

UI action is disabled for several selected classes or packages #882#896
Vassiliy-Kudryashov merged 2 commits into
mainfrom
Vassiliy-Kudryashov/882-ui-action-is-disabled-for-several-selected-classes-or-packages

Conversation

@Vassiliy-Kudryashov

Copy link
Copy Markdown
Member

Description

Better selection management was provided for the context

Fixes #882

Type of Change

Please delete options that are not relevant.

  • Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Manual Scenario

See the issue

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • No new warnings

@volivan239

Copy link
Copy Markdown
Collaborator

If multiple packages or .java-files are selected, classes from them are not included. Is this the expected behavior?

@volivan239

volivan239 commented Sep 9, 2022

Copy link
Copy Markdown
Collaborator

Seems weird that previously we used PsiElementHandler.containingClass but now we use com.intellij.psi.PsiElement.containingClass for the same purpose. If second one works correctly, shouldn't we delete containingClass from PsiElementHandler (maybe in another PR)?

@volivan239 volivan239 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me with the latest changes!

@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit 40d1215 into main Sep 12, 2022
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the Vassiliy-Kudryashov/882-ui-action-is-disabled-for-several-selected-classes-or-packages branch September 12, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI action is disabled for several selected classes or packages

2 participants